Skip to content

Bugfix FXIOS-15837 Search bar not visible after rotation (backport #33913)#33921

Open
mergify[bot] wants to merge 2 commits into
release/v151.1from
mergify/bp/release/v151.1/pr-33913
Open

Bugfix FXIOS-15837 Search bar not visible after rotation (backport #33913)#33921
mergify[bot] wants to merge 2 commits into
release/v151.1from
mergify/bp/release/v151.1/pr-33913

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented May 20, 2026

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR fixes the bug related to the search bar that will disappear while editing after rotating from landscape to portrait mode.

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

This is an automatic backport of pull request #33913 done by [Mergify](https://mergify.com).

(cherry picked from commit 318f61c)

# Conflicts:
#	firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
@mergify mergify Bot requested a review from a team as a code owner May 20, 2026 15:10
@mergify mergify Bot added the conflicts label May 20, 2026
@mergify mergify Bot requested review from Cramsden and removed request for a team May 20, 2026 15:10
@mergify mergify Bot added the conflicts label May 20, 2026
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented May 20, 2026

Cherry-pick of 318f61c has failed:

On branch mergify/bp/release/v151.1/pr-33913
Your branch is up to date with 'origin/release/v151.1'.

You are currently cherry-picking commit 318f61cd7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@rilury
Copy link
Copy Markdown
Collaborator

rilury commented May 20, 2026

merge conflict fixed

@rilury
Copy link
Copy Markdown
Collaborator

rilury commented May 20, 2026

[User impact if declined]:
Search bar can stay hidden behind the keyboard after rotation while editing.

[Is this code covered by automated tests?]
Unknown

[Has the fix been verified in Nightly?]
No

[Needs manual test from QA?]
Yes

[If yes, steps to reproduce]:
Bottom search bar → enable suggestions + Firefox Suggest → type 1–2 chars → rotate landscape → portrait. Search bar should stay visible above keyboard.

[Risk to taking this patch]
Low

[Why is the change not risky?]
Only skips keyboardWillHide while bottom bar is editing; normal dismiss unchanged.

[String changes made/needed]
None

@mobiletest-ci-bot
Copy link
Copy Markdown

‼️ ATTENTION ‼️

🎯 This PR targets a release branch.

Please ensure you've followed the uplift request process.

Generated by 🚫 Danger Swift against c852577

@DonalMe DonalMe requested review from a team and removed request for Cramsden May 20, 2026 15:40
@rilury rilury removed the conflicts label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants